fix(acp): keep the agent's model list order and drop the codex-acp smoke test (#12823)

Co-authored-by: deep-flash <bb8ecbe90ceb6a9569587bbe36250f224b37826517a32998f35634d0b431ecc2@meshllm.communities.buzz.xyz>
This commit is contained in:
James Dumay
2026-10-14 20:23:32 +00:00
committed by GitHub
parent 39c540b05b
commit 06c5d73af3
2 changed files with 7 additions and 9 deletions
+7
View File
@@ -683,6 +683,13 @@ impl Provider for AcpProvider {
Some(self.acp_session_id().to_string())
}
fn skip_canonical_filtering(&self) -> bool {
// ACP agents advertise their own model ids, which are CLI/account-specific
// and often absent from the canonical registry, and the agent's order is
// its priority order. Keep the live list intact for inventory/config.
true
}
async fn resume(&self, session_id: &str) -> Result<(), ProviderError> {
if self.acp_session_id().0.as_ref() == session_id {
return Ok(());
-9
View File
@@ -950,15 +950,6 @@ async fn test_claude_acp_provider() -> Result<()> {
.await
}
// Requires: npm install -g @agentclientprotocol/codex-acp
#[tokio::test]
async fn test_codex_acp_provider() -> Result<()> {
ProviderTestConfig::with_agentic_provider("codex-acp", ACP_CURRENT_MODEL, "codex-acp")
.model_switch_name("gpt-5.4-mini")
.run()
.await
}
// Requires: npm install -g @github/copilot
#[tokio::test]
async fn test_copilot_acp_provider() -> Result<()> {