From 06c5d73af3e7eb29633c31462a7cab274062ef1b Mon Sep 17 00:00:00 2001 From: James Dumay Date: Wed, 14 Oct 2026 20:23:32 +0000 Subject: [PATCH] fix(acp): keep the agent's model list order and drop the codex-acp smoke test (#12823) Co-authored-by: deep-flash --- crates/goose/src/acp/provider.rs | 7 +++++++ crates/goose/tests/providers.rs | 9 --------- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/crates/goose/src/acp/provider.rs b/crates/goose/src/acp/provider.rs index f71c35680..308f5bc35 100644 --- a/crates/goose/src/acp/provider.rs +++ b/crates/goose/src/acp/provider.rs @@ -683,6 +683,13 @@ impl Provider for AcpProvider { Some(self.acp_session_id().to_string()) } + fn skip_canonical_filtering(&self) -> bool { + // ACP agents advertise their own model ids, which are CLI/account-specific + // and often absent from the canonical registry, and the agent's order is + // its priority order. Keep the live list intact for inventory/config. + true + } + async fn resume(&self, session_id: &str) -> Result<(), ProviderError> { if self.acp_session_id().0.as_ref() == session_id { return Ok(()); diff --git a/crates/goose/tests/providers.rs b/crates/goose/tests/providers.rs index 2f6424aee..84178a87e 100644 --- a/crates/goose/tests/providers.rs +++ b/crates/goose/tests/providers.rs @@ -950,15 +950,6 @@ async fn test_claude_acp_provider() -> Result<()> { .await } -// Requires: npm install -g @agentclientprotocol/codex-acp -#[tokio::test] -async fn test_codex_acp_provider() -> Result<()> { - ProviderTestConfig::with_agentic_provider("codex-acp", ACP_CURRENT_MODEL, "codex-acp") - .model_switch_name("gpt-5.4-mini") - .run() - .await -} - // Requires: npm install -g @github/copilot #[tokio::test] async fn test_copilot_acp_provider() -> Result<()> {