fix: Recipe slash command doesn't work with single optional parameter (#6235)

Co-authored-by: tlongwell-block <109685178+tlongwell-block@users.noreply.github.com> Co-authored-by: David Katz <dkatz@squareup.com>
2026-01-13 19:06:13 -05:00
parent bb209498d6
commit e8247e283a
1 changed files with 8 additions and 3 deletions
@@ -94,10 +94,15 @@ where
            .parameters;

    let param_pairs: Vec<(String, String)> = if let Some(recipe_params) = &recipe_parameters {
-        if params.len() < recipe_params.len() {
-            let param_keys: Vec<String> = recipe_params.iter().map(|p| p.key.clone()).collect();
+        let required_count = recipe_params.iter().filter(|p| p.default.is_none()).count();
+        if params.len() < required_count {
+            let required_keys: Vec<String> = recipe_params
+                .iter()
+                .filter(|p| p.default.is_none())
+                .map(|p| p.key.clone())
+                .collect();
            return Err(RecipeError::MissingParams {
-                parameters: param_keys,
+                parameters: required_keys,
            });
        }
        recipe_params