fix(extensions/desktop): only show env vars for stdio mcps (#5430)

This commit is contained in:
Alex Hancock
2025-10-29 12:14:26 -04:00
committed by GitHub
parent 1d06af1f82
commit f98458323f
@@ -353,7 +353,6 @@ export default function ExtensionModal({
submitAttempted={submitAttempted} submitAttempted={submitAttempted}
/> />
{/* Divider */}
<hr className="border-t border-borderSubtle" /> <hr className="border-t border-borderSubtle" />
{/* Command */} {/* Command */}
@@ -374,42 +373,43 @@ export default function ExtensionModal({
/> />
</div> </div>
{/* Divider */} {formData.type === 'stdio' && (
<hr className="border-t border-borderSubtle" /> <>
<hr className="border-t border-borderSubtle" />
{/* Environment Variables */} <div>
<div> <EnvVarsSection
<EnvVarsSection envVars={formData.envVars}
envVars={formData.envVars} onAdd={handleAddEnvVar}
onAdd={handleAddEnvVar} onRemove={handleRemoveEnvVar}
onRemove={handleRemoveEnvVar} onChange={handleEnvVarChange}
onChange={handleEnvVarChange} submitAttempted={submitAttempted}
submitAttempted={submitAttempted} onPendingInputChange={setHasPendingEnvVars}
onPendingInputChange={setHasPendingEnvVars} />
/> </div>
</div> </>
)}
{formData.type === 'streamable_http' && (
<>
{/* Divider */}
<hr className="border-t border-borderSubtle" />
<div>
<HeadersSection
headers={formData.headers}
onAdd={handleAddHeader}
onRemove={handleRemoveHeader}
onChange={handleHeaderChange}
submitAttempted={submitAttempted}
onPendingInputChange={handlePendingHeaderChange}
/>
</div>
</>
)}
</div> </div>
)} )}
{/* Request Headers - Only for streamable_http */}
{formData.type === 'streamable_http' && (
<>
{/* Divider */}
<hr className="border-t border-borderSubtle mb-4" />
<div className="mb-6">
<HeadersSection
headers={formData.headers}
onAdd={handleAddHeader}
onRemove={handleRemoveHeader}
onChange={handleHeaderChange}
submitAttempted={submitAttempted}
onPendingInputChange={handlePendingHeaderChange}
/>
</div>
</>
)}
<DialogFooter className="pt-2"> <DialogFooter className="pt-2">
{showDeleteConfirmation ? ( {showDeleteConfirmation ? (
<> <>