From c9c03222d1842fd77041295f758d65bc5af5a111 Mon Sep 17 00:00:00 2001 From: Jeremy Collins Date: Mon, 3 Feb 2025 20:43:45 -0500 Subject: [PATCH] fix: Allow port 443 to be used with https (ollama provider) (#1052) --- crates/goose/src/providers/ollama.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/goose/src/providers/ollama.rs b/crates/goose/src/providers/ollama.rs index 6815cfa3..e0812458 100644 --- a/crates/goose/src/providers/ollama.rs +++ b/crates/goose/src/providers/ollama.rs @@ -65,7 +65,8 @@ impl OllamaProvider { .map_err(|e| ProviderError::RequestFailed(format!("Invalid base URL: {e}")))?; // Set the default port if missing - if base_url.port().is_none() { + let explicit_default_port = self.host.ends_with(":80") || self.host.ends_with(":443"); + if base_url.port().is_none() && !explicit_default_port { base_url.set_port(Some(OLLAMA_DEFAULT_PORT)).map_err(|_| { ProviderError::RequestFailed("Failed to set default port".to_string()) })?;