From c2f5889ae5ea04e0a88c024337b345bc07651e0b Mon Sep 17 00:00:00 2001 From: Rabi Mishra Date: Wed, 28 Jan 2026 22:35:57 +0530 Subject: [PATCH] fix: respect GOOSE_CLI_MIN_PRIORITY for shell streaming output (#6558) Signed-off-by: rabi --- crates/goose-cli/src/session/mod.rs | 20 ++++++++++++++------ crates/goose-cli/src/session/output.rs | 4 +++- 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/crates/goose-cli/src/session/mod.rs b/crates/goose-cli/src/session/mod.rs index 7d31aae8..f3aea7cb 100644 --- a/crates/goose-cli/src/session/mod.rs +++ b/crates/goose-cli/src/session/mod.rs @@ -1595,7 +1595,7 @@ fn format_logging_notification( let min_priority = config .get_param::("GOOSE_CLI_MIN_PRIORITY") .ok() - .unwrap_or(0.5); + .unwrap_or(output::DEFAULT_MIN_PRIORITY); if min_priority > 0.1 && !debug { if let Some(response_content) = msg.strip_prefix("Responded: ") { @@ -1655,11 +1655,19 @@ fn display_log_notification( std::io::stdout().flush().unwrap(); } } else if ntype == "shell_output" { - if interactive { - let _ = progress_bars.hide(); - } - if !is_json_mode { - println!("{}", formatted_message); + let config = Config::global(); + let min_priority = config + .get_param::("GOOSE_CLI_MIN_PRIORITY") + .ok() + .unwrap_or(output::DEFAULT_MIN_PRIORITY); + + if min_priority < 0.1 { + if interactive { + let _ = progress_bars.hide(); + } + if !is_json_mode { + println!("{}", formatted_message); + } } } } else if output::is_showing_thinking() { diff --git a/crates/goose-cli/src/session/output.rs b/crates/goose-cli/src/session/output.rs index 89b26c66..fb4a778a 100644 --- a/crates/goose-cli/src/session/output.rs +++ b/crates/goose-cli/src/session/output.rs @@ -17,6 +17,8 @@ use std::path::Path; use std::sync::Arc; use std::time::Duration; +pub const DEFAULT_MIN_PRIORITY: f32 = 0.0; + // Re-export theme for use in main #[derive(Clone, Copy)] pub enum Theme { @@ -308,7 +310,7 @@ fn render_tool_response(resp: &ToolResponse, theme: Theme, debug: bool) { let min_priority = config .get_param::("GOOSE_CLI_MIN_PRIORITY") .ok() - .unwrap_or(0.5); + .unwrap_or(DEFAULT_MIN_PRIORITY); if content .priority()