fix: pr number needs to be outputted from trigger job (#770)

This commit is contained in:
Salman Mohammed
2025-01-25 16:26:11 -05:00
committed by GitHub
parent 4d2eb00b58
commit b5071351c2
@@ -12,7 +12,7 @@ on:
permissions: permissions:
pull-requests: write pull-requests: write
checks: read checks: read
issues: write # issues: write
name: Workflow to Bundle Desktop App name: Workflow to Bundle Desktop App
@@ -26,6 +26,8 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
outputs: outputs:
continue: ${{ steps.command.outputs.continue }} continue: ${{ steps.command.outputs.continue }}
# Cannot use github.event.pull_request.number since the trigger is 'issue_comment'
pr_number: ${{ steps.command.outputs.issue_number }}
steps: steps:
- uses: github/command@v1.3.0 - uses: github/command@v1.3.0
id: command id: command
@@ -33,10 +35,6 @@ jobs:
command: ".bundle" command: ".bundle"
reaction: "eyes" reaction: "eyes"
allowed_contexts: pull_request allowed_contexts: pull_request
- name: Echo outputs
run: |
echo "Pull Request number is: '${{ steps.command.outputs.issue_number }}'
echo "Comment ID is: '${{ steps.command.outputs.comment_id }}'
bundle-desktop: bundle-desktop:
# Only run this if ".bundle" command is detected. # Only run this if ".bundle" command is detected.
@@ -65,14 +63,10 @@ jobs:
with: with:
merge-multiple: true merge-multiple: true
- name: Debug pull_request number
run: |
echo "Pull Request number is: '${{ github.event.pull_request.number }}'"
- name: Comment on PR with download link - name: Comment on PR with download link
uses: peter-evans/create-or-update-comment@v4 uses: peter-evans/create-or-update-comment@v4
with: with:
issue-number: ${{ github.event.pull_request.number }} issue-number: ${{ needs.trigger-on-command.outputs.pr_number }}
body: | body: |
### Desktop App for this PR ### Desktop App for this PR
@@ -83,4 +77,3 @@ jobs:
After downloading, unzip the file and drag the Goose.app to your Applications folder. The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder. The app is signed and notarized for macOS.
This link is provided by nightly.link and will work even if you're not logged into GitHub. This link is provided by nightly.link and will work even if you're not logged into GitHub.
edit-mode: replace