fix(cli): multiselect visibility for light themes (#1716)
This commit is contained in:
@@ -10,6 +10,10 @@ use serde_json::{json, Value};
|
|||||||
use std::collections::HashMap;
|
use std::collections::HashMap;
|
||||||
use std::error::Error;
|
use std::error::Error;
|
||||||
|
|
||||||
|
// useful for light themes where there is no dicernible colour contrast between
|
||||||
|
// cursor-selected and cursor-unselected items.
|
||||||
|
const MULTISELECT_VISIBILITY_HINT: &str = "<";
|
||||||
|
|
||||||
fn get_display_name(extension_id: &str) -> String {
|
fn get_display_name(extension_id: &str) -> String {
|
||||||
match extension_id {
|
match extension_id {
|
||||||
"developer" => "Developer Tools".to_string(),
|
"developer" => "Developer Tools".to_string(),
|
||||||
@@ -408,7 +412,7 @@ pub fn toggle_extensions_dialog() -> Result<(), Box<dyn Error>> {
|
|||||||
.items(
|
.items(
|
||||||
&extension_status
|
&extension_status
|
||||||
.iter()
|
.iter()
|
||||||
.map(|(name, _)| (name, name.as_str(), ""))
|
.map(|(name, _)| (name, name.as_str(), MULTISELECT_VISIBILITY_HINT))
|
||||||
.collect::<Vec<_>>(),
|
.collect::<Vec<_>>(),
|
||||||
)
|
)
|
||||||
.initial_values(enabled_extensions)
|
.initial_values(enabled_extensions)
|
||||||
@@ -719,7 +723,7 @@ pub fn remove_extension_dialog() -> Result<(), Box<dyn Error>> {
|
|||||||
&disabled_extensions
|
&disabled_extensions
|
||||||
.iter()
|
.iter()
|
||||||
.filter(|(_, enabled)| !enabled)
|
.filter(|(_, enabled)| !enabled)
|
||||||
.map(|(name, _)| (name, name.as_str(), ""))
|
.map(|(name, _)| (name, name.as_str(), MULTISELECT_VISIBILITY_HINT))
|
||||||
.collect::<Vec<_>>(),
|
.collect::<Vec<_>>(),
|
||||||
)
|
)
|
||||||
.interact()?;
|
.interact()?;
|
||||||
@@ -872,7 +876,7 @@ pub fn toggle_experiments_dialog() -> Result<(), Box<dyn Error>> {
|
|||||||
.items(
|
.items(
|
||||||
&experiments
|
&experiments
|
||||||
.iter()
|
.iter()
|
||||||
.map(|(name, _)| (name, name.as_str(), ""))
|
.map(|(name, _)| (name, name.as_str(), MULTISELECT_VISIBILITY_HINT))
|
||||||
.collect::<Vec<_>>(),
|
.collect::<Vec<_>>(),
|
||||||
)
|
)
|
||||||
.initial_values(enabled_experiments)
|
.initial_values(enabled_experiments)
|
||||||
|
|||||||
Reference in New Issue
Block a user