refactor: remove allows_unlisted_models flag, always allow custom model entry (#7255)

Signed-off-by: clayarnoldg2m <carnold@g2m.ai>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

crates/goose-cli/src/commands/configure.rs

@@ -466,13 +466,11 @@ fn select_model_from_list(
                 ),
             );
 
-            if provider_meta.allows_unlisted_models {
-                model_items.push((
-                    UNLISTED_MODEL_KEY.to_string(),
-                    "Enter a model not listed...".to_string(),
-                    "",
-                ));
-            }
+            model_items.push((
+                UNLISTED_MODEL_KEY.to_string(),
+                "Enter a model not listed...".to_string(),
+                "",
+            ));
 
             let selection = cliclack::select("Select a model:")
                 .items(&model_items)
@@ -492,13 +490,11 @@ fn select_model_from_list(
         let mut model_items: Vec<(String, String, &str)> =
             models.iter().map(|m| (m.clone(), m.clone(), "")).collect();
 
-        if provider_meta.allows_unlisted_models {
-            model_items.push((
-                UNLISTED_MODEL_KEY.to_string(),
-                "Enter a model not listed...".to_string(),
-                "",
-            ));
-        }
+        model_items.push((
+            UNLISTED_MODEL_KEY.to_string(),
+            "Enter a model not listed...".to_string(),
+            "",
+        ));
 
         let selection = cliclack::select("Select a model:")
             .items(&model_items)

crates/goose/src/providers/base.rs

@@ -175,9 +175,6 @@ pub struct ProviderMetadata {
     pub model_doc_link: String,
     /// Required configuration keys
     pub config_keys: Vec<ConfigKey>,
-    /// Whether this provider allows entering model names not in the fetched list
-    #[serde(default)]
-    pub allows_unlisted_models: bool,
 }
 
 impl ProviderMetadata {
@@ -210,7 +207,6 @@ impl ProviderMetadata {
                 .collect(),
             model_doc_link: model_doc_link.to_string(),
             config_keys,
-            allows_unlisted_models: false,
         }
     }
 
@@ -231,7 +227,6 @@ impl ProviderMetadata {
             known_models: models,
             model_doc_link: model_doc_link.to_string(),
             config_keys,
-            allows_unlisted_models: false,
         }
     }
 
@@ -244,15 +239,8 @@ impl ProviderMetadata {
             known_models: vec![],
             model_doc_link: "".to_string(),
             config_keys: vec![],
-            allows_unlisted_models: false,
         }
     }
-
-    /// Set allows_unlisted_models flag (builder pattern)
-    pub fn with_unlisted_models(mut self) -> Self {
-        self.allows_unlisted_models = true;
-        self
-    }
 }
 
 /// Configuration key metadata for provider setup

crates/goose/src/providers/chatgpt_codex.rs

@@ -864,7 +864,6 @@ impl ProviderDef for ChatGptCodexProvider {
                 false,
             )],
         )
-        .with_unlisted_models()
     }
 
     fn from_env(

crates/goose/src/providers/claude_code.rs

@@ -487,10 +487,6 @@ impl ProviderDef for ClaudeCodeProvider {
                 true, false, true,
             )],
         )
-        // The model list only returns aliases the `claude` CLI uses, such as "default"
-        // and "haiku". There is no listing that includes full names like
-        // "claude-sonnet-4-5-20250929". However, they are permitted.
-        .with_unlisted_models()
     }
 
     fn from_env(

crates/goose/src/providers/codex.rs

@@ -605,7 +605,6 @@ impl ProviderDef for CodexProvider {
                 ConfigKey::from_value_type::<CodexSkipGitCheck>(false, false, true),
             ],
         )
-        .with_unlisted_models()
     }
 
     fn from_env(

crates/goose/src/providers/cursor_agent.rs

@@ -294,7 +294,6 @@ impl ProviderDef for CursorAgentProvider {
                 true, false, true,
             )],
         )
-        .with_unlisted_models()
     }
 
     fn from_env(

crates/goose/src/providers/gcpvertexai.rs

@@ -541,7 +541,6 @@ impl ProviderDef for GcpVertexAIProvider {
                 ),
             ],
         )
-        .with_unlisted_models()
     }
 
     fn from_env(
@@ -742,6 +741,5 @@ mod tests {
         assert!(!metadata.known_models.is_empty());
         assert_eq!(metadata.default_model, "gemini-2.5-flash");
         assert_eq!(metadata.config_keys.len(), 6);
-        assert!(metadata.allows_unlisted_models);
     }
 }

crates/goose/src/providers/gemini_cli.rs

@@ -169,7 +169,6 @@ impl ProviderDef for GeminiCliProvider {
                 true, false, true,
             )],
         )
-        .with_unlisted_models()
     }
 
     fn from_env(

crates/goose/src/providers/openrouter.rs

@@ -168,7 +168,6 @@ impl ProviderDef for OpenRouterProvider {
                 ),
             ],
         )
-        .with_unlisted_models()
     }
 
     fn from_env(

crates/goose/src/providers/provider_registry.rs

@@ -127,7 +127,6 @@ impl ProviderRegistry {
             known_models,
             model_doc_link: base_metadata.model_doc_link,
             config_keys,
-            allows_unlisted_models: false,
         };
 
         self.entries.insert(

crates/goose/tests/agent.rs

@@ -372,7 +372,6 @@ mod tests {
                     known_models: vec![],
                     model_doc_link: "".to_string(),
                     config_keys: vec![],
-                    allows_unlisted_models: false,
                 }
             }
 

crates/goose/tests/compaction.rs

@@ -190,7 +190,6 @@ impl ProviderDef for MockCompactionProvider {
             known_models: vec![],
             model_doc_link: "".to_string(),
             config_keys: vec![],
-            allows_unlisted_models: false,
         }
     }