custom instructions for copilot reviews (#5646)
This commit is contained in:
@@ -76,6 +76,17 @@ Provider: Implement Provider trait see providers/base.rs
|
||||
MCP: Extensions in crates/goose-mcp/
|
||||
Server: Changes need just generate-openapi
|
||||
|
||||
## Code Quality
|
||||
|
||||
Comments: Write self-documenting code - prefer clear names over comments
|
||||
Comments: Never add comments that restate what code does
|
||||
Comments: Only comment for complex algorithms, non-obvious business logic, or "why" not "what"
|
||||
Simplicity: Don't make things optional that don't need to be - the compiler will enforce
|
||||
Simplicity: Booleans should default to false, not be optional
|
||||
Errors: Don't add error context that doesn't add useful information (e.g., `.context("Failed to X")` when error already says it failed)
|
||||
Simplicity: Avoid overly defensive code - trust Rust's type system
|
||||
Logging: Clean up existing logs, don't add more
|
||||
|
||||
## Never
|
||||
|
||||
Never: Edit ui/desktop/openapi.json manually
|
||||
|
||||
Reference in New Issue
Block a user