tkmind/tkmind_go
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

refactor: convert desktop v1 and goose-server extensions to ACP+ (#9448)

Browse Source
This commit is contained in:
Alex Hancock
2026-05-27 16:59:48 -04:00
committed by GitHub
parent c9945bca5d
commit 9c403b1560
13 changed files with 124 additions and 826 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ui/desktop/src/acp/extensions.ts
+88 -3
View File
@@ -1,11 +1,96 @@
import type { ExtensionResponse, ExtensionEntry } from '../api';
import type { ExtensionEntry, ExtensionConfig } from '../api';
import { getAcpClient } from './acpConnection';
export async function getConfiguredExtensions(): Promise<ExtensionResponse> {
export interface ConfiguredExtensionsResponse {
extensions: ExtensionEntry[];
warnings: string[];
}
/**
* Fetch all configured extensions via ACP (`_goose/unstable/config/extensions/list`).
*/
export async function getConfiguredExtensions(): Promise<ConfiguredExtensionsResponse> {
const client = await getAcpClient();
const response = await client.goose.configExtensionsList_unstable({});
return {
extensions: response.extensions as ExtensionEntry[],
warnings: response.warnings,
warnings: response.warnings ?? [],
};
}
/**
* Add (or update) an extension in the user's global goose config via ACP
* (`_goose/unstable/config/extensions/add`).
*/
export async function addConfiguredExtension(
name: string,
config: ExtensionConfig,
enabled: boolean
): Promise<void> {
const client = await getAcpClient();
// Server expects a JSON object matching one of the ExtensionConfig variants,
// and injects `name` itself. We strip `name` from the body to match that shape.
const extensionConfig = { ...config } as Record<string, unknown>;
delete extensionConfig.name;
await client.goose.configExtensionsAdd_unstable({
name,
extensionConfig,
enabled,
});
}
/**
* Remove an extension from the user's global goose config via ACP
* (`_goose/unstable/config/extensions/remove`). The server normalizes the
* supplied `configKey` via `name_to_key`, so passing the raw extension name
* is sufficient and matches how the previous REST route worked.
*/
export async function removeConfiguredExtension(name: string): Promise<void> {
const client = await getAcpClient();
await client.goose.configExtensionsRemove_unstable({
configKey: name,
});
}
/**
* Add an extension to a running session's agent via ACP
* (`_goose/unstable/session/extensions/add`).
*/
export async function addSessionExtension(
sessionId: string,
config: ExtensionConfig
): Promise<void> {
const client = await getAcpClient();
await client.goose.sessionExtensionsAdd_unstable({
sessionId,
config,
});
}
/**
* Remove an extension from a running session's agent via ACP
* (`_goose/unstable/session/extensions/remove`).
*/
export async function removeSessionExtension(
sessionId: string,
name: string
): Promise<void> {
const client = await getAcpClient();
await client.goose.sessionExtensionsRemove_unstable({
sessionId,
name,
});
}
/**
* Fetch the list of extensions associated with a given session via ACP
* (`_goose/unstable/session/extensions/list`).
*/
export async function getSessionExtensions(
sessionId: string
): Promise<ExtensionEntry[]> {
const client = await getAcpClient();
const response = await client.goose.sessionExtensionsList_unstable({ sessionId });
return response.extensions as ExtensionEntry[];
}
ui/desktop/src/api/index.ts
+2 -2
View File
File diff suppressed because one or more lines are too long
ui/desktop/src/api/sdk.gen.ts
+1 -34
View File
File diff suppressed because one or more lines are too long
ui/desktop/src/api/types.gen.ts
-206
View File
@@ -25,11 +25,6 @@ export type ActionRequiredData = {
user_data: unknown;
};
export type AddExtensionRequest = {
config: ExtensionConfig;
session_id: string;
};
export type Annotations = {
audience?: Array<Role>;
lastModified?: string;
@@ -493,17 +488,6 @@ export type ExtensionLoadResult = {
success: boolean;
};
export type ExtensionQuery = {
config: ExtensionConfig;
enabled: boolean;
name: string;
};
export type ExtensionResponse = {
extensions: Array<ExtensionEntry>;
warnings?: Array<string>;
};
export type FeaturesResponse = {
/**
* Map of feature name to enabled status
@@ -1152,11 +1136,6 @@ export type RedactedThinkingContent = {
data: string;
};
export type RemoveExtensionRequest = {
name: string;
session_id: string;
};
export type RepoVariantsResponse = {
available_memory_bytes: number;
downloaded_quants: Array<string>;
@@ -1348,10 +1327,6 @@ export type SessionDisplayInfo = {
workingDir: string;
};
export type SessionExtensionsResponse = {
extensions: Array<ExtensionConfig>;
};
export type SessionInsights = {
totalSessions: number;
totalTokens: number;
@@ -1781,37 +1756,6 @@ export type ConfirmToolActionResponses = {
200: unknown;
};
export type AgentAddExtensionData = {
body: AddExtensionRequest;
path?: never;
query?: never;
url: '/agent/add_extension';
};
export type AgentAddExtensionErrors = {
/**
* Unauthorized - invalid secret key
*/
401: unknown;
/**
* Agent not initialized
*/
424: unknown;
/**
* Internal server error
*/
500: unknown;
};
export type AgentAddExtensionResponses = {
/**
* Extension added
*/
200: string;
};
export type AgentAddExtensionResponse = AgentAddExtensionResponses[keyof AgentAddExtensionResponses];
export type CallToolData = {
body: CallToolRequest;
path?: never;
@@ -1982,37 +1926,6 @@ export type ReadResourceResponses = {
export type ReadResourceResponse2 = ReadResourceResponses[keyof ReadResourceResponses];
export type AgentRemoveExtensionData = {
body: RemoveExtensionRequest;
path?: never;
query?: never;
url: '/agent/remove_extension';
};
export type AgentRemoveExtensionErrors = {
/**
* Unauthorized - invalid secret key
*/
401: unknown;
/**
* Agent not initialized
*/
424: unknown;
/**
* Internal server error
*/
500: unknown;
};
export type AgentRemoveExtensionResponses = {
/**
* Extension removed
*/
200: string;
};
export type AgentRemoveExtensionResponse = AgentRemoveExtensionResponses[keyof AgentRemoveExtensionResponses];
export type RestartAgentData = {
body: RestartAgentRequest;
path?: never;
@@ -2448,89 +2361,6 @@ export type UpdateCustomProviderResponses = {
export type UpdateCustomProviderResponse = UpdateCustomProviderResponses[keyof UpdateCustomProviderResponses];
export type GetExtensionsData = {
body?: never;
path?: never;
query?: never;
url: '/config/extensions';
};
export type GetExtensionsErrors = {
/**
* Internal server error
*/
500: unknown;
};
export type GetExtensionsResponses = {
/**
* All extensions retrieved successfully
*/
200: ExtensionResponse;
};
export type GetExtensionsResponse = GetExtensionsResponses[keyof GetExtensionsResponses];
export type AddExtensionData = {
body: ExtensionQuery;
path?: never;
query?: never;
url: '/config/extensions';
};
export type AddExtensionErrors = {
/**
* Invalid request
*/
400: unknown;
/**
* Could not serialize config.yaml
*/
422: unknown;
/**
* Internal server error
*/
500: unknown;
};
export type AddExtensionResponses = {
/**
* Extension added or updated successfully
*/
200: string;
};
export type AddExtensionResponse = AddExtensionResponses[keyof AddExtensionResponses];
export type RemoveExtensionData = {
body?: never;
path: {
name: string;
};
query?: never;
url: '/config/extensions/{name}';
};
export type RemoveExtensionErrors = {
/**
* Extension not found
*/
404: unknown;
/**
* Internal server error
*/
500: unknown;
};
export type RemoveExtensionResponses = {
/**
* Extension removed successfully
*/
200: string;
};
export type RemoveExtensionResponse = RemoveExtensionResponses[keyof RemoveExtensionResponses];
export type UpsertPermissionsData = {
body: UpsertPermissionsQuery;
path?: never;
@@ -4496,42 +4326,6 @@ export type ExportSessionResponses = {
export type ExportSessionResponse = ExportSessionResponses[keyof ExportSessionResponses];
export type GetSessionExtensionsData = {
body?: never;
path: {
/**
* Unique identifier for the session
*/
session_id: string;
};
query?: never;
url: '/sessions/{session_id}/extensions';
};
export type GetSessionExtensionsErrors = {
/**
* Unauthorized - Invalid or missing API key
*/
401: unknown;
/**
* Session not found
*/
404: unknown;
/**
* Internal server error
*/
500: unknown;
};
export type GetSessionExtensionsResponses = {
/**
* Session extensions retrieved successfully
*/
200: SessionExtensionsResponse;
};
export type GetSessionExtensionsResponse = GetSessionExtensionsResponses[keyof GetSessionExtensionsResponses];
export type ForkSessionData = {
body: ForkRequest;
path: {
ui/desktop/src/components/ConfigContext.tsx
+9 -18
View File
@@ -1,21 +1,16 @@
import React, { createContext, useContext, useState, useEffect, useMemo, useCallback } from 'react';
import { readAllConfig, readConfig, removeConfig, upsertConfig, providers } from '../api';
import {
readAllConfig,
readConfig,
removeConfig,
upsertConfig,
addExtension as apiAddExtension,
removeExtension as apiRemoveExtension,
providers,
} from '../api';
import { getConfiguredExtensions } from '../acp/extensions';
getConfiguredExtensions,
addConfiguredExtension,
removeConfiguredExtension,
} from '../acp/extensions';
import { pruneDeprecatedBundledExtensions, syncBundledExtensions } from './settings/extensions';
import type {
ConfigResponse,
UpsertConfigQuery,
ConfigKeyQuery,
ProviderDetails,
ExtensionQuery,
ExtensionConfig,
} from '../api';
@@ -113,10 +108,7 @@ export const ConfigProvider: React.FC<ConfigProviderProps> = ({ children }) => {
const addExtension = useCallback(
async (name: string, config: ExtensionConfig, enabled: boolean) => {
const query: ExtensionQuery = { name, config, enabled };
await apiAddExtension({
body: query,
});
await addConfiguredExtension(name, config, enabled);
await reloadConfig();
// Refresh extensions list after successful addition
await refreshExtensions();
@@ -126,7 +118,7 @@ export const ConfigProvider: React.FC<ConfigProviderProps> = ({ children }) => {
const removeExtension = useCallback(
async (name: string) => {
await apiRemoveExtension({ path: { name: name } });
await removeConfiguredExtension(name);
await reloadConfig();
// Refresh extensions list after successful removal
await refreshExtensions();
@@ -206,11 +198,10 @@ export const ConfigProvider: React.FC<ConfigProviderProps> = ({ children }) => {
config: ExtensionConfig,
enabled: boolean
) => {
const query: ExtensionQuery = { name, config, enabled };
await apiAddExtension({ body: query });
await addConfiguredExtension(name, config, enabled);
};
const removeExtensionForSync = async (name: string) => {
await apiRemoveExtension({ path: { name } });
await removeConfiguredExtension(name);
};
extensions = await pruneDeprecatedBundledExtensions(extensions, removeExtensionForSync);
await syncBundledExtensions(extensions, addExtensionForSync);
ui/desktop/src/components/bottom_menu/BottomMenuExtensionSelection.tsx
+7 -16
View File
@@ -8,7 +8,8 @@ import { FixedExtensionEntry, useConfig } from '../ConfigContext';
import { toastService } from '../../toasts';
import { formatExtensionName } from '../settings/extensions/subcomponents/ExtensionList';
import { nameToKey } from '../settings/extensions/utils';
import { ExtensionConfig, getSessionExtensions } from '../../api';
import { ExtensionConfig } from '../../api';
import { getSessionExtensions } from '../../acp/extensions';
import { addToAgent, removeFromAgent } from '../settings/extensions/agent-api';
import {
setExtensionOverride,
@@ -119,14 +120,9 @@ export const BottomMenuExtensionSelection = ({ sessionId }: BottomMenuExtensionS
}
try {
const response = await getSessionExtensions({
path: { session_id: sessionId },
});
if (response.data?.extensions) {
setSessionExtensions(response.data.extensions);
setIsSessionExtensionsLoaded(true);
}
const extensions = await getSessionExtensions(sessionId);
setSessionExtensions(extensions);
setIsSessionExtensionsLoaded(true);
} catch (error) {
console.error('Failed to fetch session extensions:', error);
setIsSessionExtensionsLoaded(true);
@@ -197,13 +193,8 @@ export const BottomMenuExtensionSelection = ({ sessionId }: BottomMenuExtensionS
}
sortTimeoutRef.current = setTimeout(async () => {
const response = await getSessionExtensions({
path: { session_id: sessionId },
});
if (response.data?.extensions) {
setSessionExtensions(response.data.extensions);
}
const extensions = await getSessionExtensions(sessionId);
setSessionExtensions(extensions);
setPendingSort(false);
setIsTransitioning(false);
setTogglingExtension(null);
ui/desktop/src/components/settings/extensions/agent-api.ts
+4 -9
View File
@@ -1,5 +1,6 @@
import { toastService } from '../../../toasts';
import { agentAddExtension, ExtensionConfig, agentRemoveExtension } from '../../../api';
import { ExtensionConfig } from '../../../api';
import { addSessionExtension, removeSessionExtension } from '../../../acp/extensions';
import { errorMessage } from '../../../utils/conversionUtils';
import {
createExtensionRecoverHints,
@@ -20,10 +21,7 @@ export async function addToAgent(
: 0;
try {
await agentAddExtension({
body: { session_id: sessionId, config: extensionConfig },
throwOnError: true,
});
await addSessionExtension(sessionId, extensionConfig);
if (showToast) {
toastService.dismiss(toastId);
toastService.success({
@@ -61,10 +59,7 @@ export async function removeFromAgent(
: 0;
try {
await agentRemoveExtension({
body: { session_id: sessionId, name: extensionName },
throwOnError: true,
});
await removeSessionExtension(sessionId, extensionName);
if (showToast) {
toastService.dismiss(toastId);
toastService.success({