feat: add grouped extension loading notification (#5529)

Signed-off-by: jom-sq <148157197+jom-sq@users.noreply.github.com>

ui/desktop/src/components/settings/extensions/agent-api.ts

@@ -1,6 +1,10 @@
 import { toastService } from '../../../toasts';
 import { agentAddExtension, ExtensionConfig, agentRemoveExtension } from '../../../api';
 import { errorMessage } from '../../../utils/conversionUtils';
+import {
+  createExtensionRecoverHints,
+  formatExtensionErrorMessage,
+} from '../../../utils/extensionErrorUtils';
 
 export async function addToAgent(
   extensionConfig: ExtensionConfig,
@@ -30,20 +34,16 @@ export async function addToAgent(
   } catch (error) {
     if (showToast) {
       toastService.dismiss(toastId);
+      const errMsg = errorMessage(error);
+      const recoverHints = createExtensionRecoverHints(errMsg);
+      const msg = formatExtensionErrorMessage(errMsg, 'Failed to add extension');
+      toastService.error({
+        title: extensionName,
+        msg: msg,
+        traceback: errMsg,
+        recoverHints,
+      });
     }
-    const errMsg = errorMessage(error);
-    const recoverHints =
-      `Explain the following error: ${errMsg}. ` +
-      'This happened while trying to install an extension. Look out for issues that the ' +
-      "extension tried to run something faulty, didn't exist or there was trouble with " +
-      'the network configuration - VPNs like WARP often cause issues.';
-    const msg = errMsg.length < 70 ? errMsg : `Failed to add extension`;
-    toastService.error({
-      title: extensionName,
-      msg: msg,
-      traceback: errMsg,
-      recoverHints,
-    });
     throw error;
   }
 }
@@ -75,14 +75,14 @@ export async function removeFromAgent(
   } catch (error) {
     if (showToast) {
       toastService.dismiss(toastId);
+      const errMsg = errorMessage(error);
+      const msg = formatExtensionErrorMessage(errMsg, 'Failed to remove extension');
+      toastService.error({
+        title: extensionName,
+        msg: msg,
+        traceback: errMsg,
+      });
     }
-    const errorMessage = error instanceof Error ? error.message : String(error);
-    const msg = errorMessage.length < 70 ? errorMessage : `Failed to remove extension`;
-    toastService.error({
-      title: extensionName,
-      msg: msg,
-      traceback: errorMessage,
-    });
     throw error;
   }
 }

ui/desktop/src/components/settings/extensions/extension-manager.test.ts

@@ -70,23 +70,18 @@ describe('Extension Manager', () => {
       expect(mockAddToAgent).toHaveBeenCalledTimes(3);
     });
 
-    it('should show error toast after max retries but keep extension enabled', async () => {
+    it('should throw error after max retries', async () => {
       const error428 = new Error('428 Precondition Required');
       mockAddToAgent.mockRejectedValue(error428);
-      mockToastService.configure = vi.fn();
-      mockToastService.error = vi.fn();
 
-      await addToAgentOnStartup({
-        sessionId: 'test-session',
-        extensionConfig: mockExtensionConfig,
-      });
+      await expect(
+        addToAgentOnStartup({
+          sessionId: 'test-session',
+          extensionConfig: mockExtensionConfig,
+        })
+      ).rejects.toThrow('428 Precondition Required');
 
       expect(mockAddToAgent).toHaveBeenCalledTimes(4); // Initial + 3 retries
-      expect(mockToastService.error).toHaveBeenCalledWith({
-        title: 'test-extension',
-        msg: 'Extension failed to start and will retry on a new session.',
-        traceback: '428 Precondition Required',
-      });
     });
   });
 

ui/desktop/src/components/settings/extensions/extension-manager.ts

@@ -96,25 +96,21 @@ interface AddToAgentOnStartupProps {
 export async function addToAgentOnStartup({
   extensionConfig,
   sessionId,
+  toastOptions,
 }: AddToAgentOnStartupProps): Promise<void> {
-  try {
-    await retryWithBackoff(() => addToAgent(extensionConfig, sessionId, true), {
-      retries: 3,
-      delayMs: 1000,
-      shouldRetry: (error: ExtensionError) =>
-        !!error.message &&
-        (error.message.includes('428') ||
-          error.message.includes('Precondition Required') ||
-          error.message.includes('Agent is not initialized')),
-    });
-  } catch (finalError) {
-    toastService.configure({ silent: false });
-    toastService.error({
-      title: extensionConfig.name,
-      msg: 'Extension failed to start and will retry on a new session.',
-      traceback: finalError instanceof Error ? finalError.message : String(finalError),
-    });
-  }
+  const showToast = !toastOptions?.silent;
+
+  // Errors are caught by the grouped notification in providerUtils.ts
+  // Individual error toasts are suppressed during startup (showToast=false)
+  await retryWithBackoff(() => addToAgent(extensionConfig, sessionId, showToast), {
+    retries: 3,
+    delayMs: 1000,
+    shouldRetry: (error: ExtensionError) =>
+      !!error.message &&
+      (error.message.includes('428') ||
+        error.message.includes('Precondition Required') ||
+        error.message.includes('Agent is not initialized')),
+  });
 }
 
 interface UpdateExtensionProps {