From 6d6c6b322812f0d8b1bcd6b0d34efc63e3412033 Mon Sep 17 00:00:00 2001 From: dorien-koelemeijer <62866702+dorien-koelemeijer@users.noreply.github.com> Date: Wed, 11 Mar 2026 23:03:18 +1000 Subject: [PATCH] More logging for command injection classifier model training (#7779) --- crates/goose/src/security/mod.rs | 9 +++++++-- crates/goose/src/security/scanner.rs | 3 +++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/crates/goose/src/security/mod.rs b/crates/goose/src/security/mod.rs index 1384ce70..3c771f03 100644 --- a/crates/goose/src/security/mod.rs +++ b/crates/goose/src/security/mod.rs @@ -165,13 +165,18 @@ impl SecurityManager { tool_request_id: tool_request.id.clone(), }); } - } else { + } else if analysis_result.scanned { + let tool_call_json = + serde_json::to_string(&tool_call).unwrap_or_else(|_| "{}".to_string()); + tracing::info!( + monotonic_counter.goose.prompt_injection_tool_call_passed = 1, tool_name = %tool_call.name, tool_request_id = %tool_request.id, + tool_call_json = %tool_call_json, confidence = analysis_result.confidence, explanation = %sanitized_explanation, - "✅ Current tool call passed security analysis" + "Current tool call passed security analysis" ); } } diff --git a/crates/goose/src/security/scanner.rs b/crates/goose/src/security/scanner.rs index 5cff251c..8d0e4e4c 100644 --- a/crates/goose/src/security/scanner.rs +++ b/crates/goose/src/security/scanner.rs @@ -21,6 +21,7 @@ pub struct ScanResult { pub is_malicious: bool, pub confidence: f32, pub explanation: String, + pub scanned: bool, } struct DetailedScanResult { @@ -127,6 +128,7 @@ impl PromptInjectionScanner { is_malicious: false, confidence: 0.0, explanation: "Tool call skipped: only shell commands are scanned".to_string(), + scanned: false, }); } @@ -180,6 +182,7 @@ impl PromptInjectionScanner { is_malicious: final_confidence >= threshold, confidence: final_confidence, explanation: self.build_explanation(&final_result, threshold, &tool_content), + scanned: true, }) }