From 65eed515559af22dde2ba965335e331422f60c26 Mon Sep 17 00:00:00 2001 From: Angie Jones Date: Sun, 5 Jul 2026 22:44:59 -0500 Subject: [PATCH] Disable thinking preservation for Groq (#10284) --- crates/goose-providers/src/declarative.rs | 9 +++------ .../src/declarative/definitions/groq.json | 3 ++- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/crates/goose-providers/src/declarative.rs b/crates/goose-providers/src/declarative.rs index d6151fae8..4062bb692 100644 --- a/crates/goose-providers/src/declarative.rs +++ b/crates/goose-providers/src/declarative.rs @@ -358,14 +358,11 @@ mod tests { } #[test] - fn existing_json_files_still_deserialize_without_new_fields() { + fn groq_json_disables_thinking_preservation() { let config = deserialize_provider_config(crate::groq::JSON).expect("groq.json should parse"); - assert!(config.env_vars.is_none()); - assert!(config.dynamic_models.is_none()); - assert!(config.model_doc_link.is_none()); - assert!(config.setup_steps.is_empty()); - assert!(config.preserves_thinking); + + assert!(!config.preserves_thinking); } fn placeholder_var_names(template: &str) -> Vec { diff --git a/crates/goose-providers/src/declarative/definitions/groq.json b/crates/goose-providers/src/declarative/definitions/groq.json index a817f55c0..6adef5395 100644 --- a/crates/goose-providers/src/declarative/definitions/groq.json +++ b/crates/goose-providers/src/declarative/definitions/groq.json @@ -57,5 +57,6 @@ "max_tokens": 1024 } ], - "supports_streaming": true + "supports_streaming": true, + "preserves_thinking": false }