fix: gemini acp without an unexpected terminal window (#8101)

This commit is contained in:
Lifei Zhou
2026-03-26 14:07:27 +11:00
committed by GitHub
parent d2553978c4
commit 59a96c986f
4 changed files with 33 additions and 8 deletions
-1
View File
@@ -11,7 +11,6 @@ impl SubprocessExt for Command {
fn set_no_window(&mut self) -> &mut Self {
#[cfg(windows)]
{
use std::os::windows::process::CommandExt;
self.creation_flags(CREATE_NO_WINDOW_FLAG);
}
self
+2
View File
@@ -32,6 +32,7 @@ use crate::permission::permission_confirmation::PrincipalType;
use crate::permission::{Permission, PermissionConfirmation};
use crate::providers::base::{MessageStream, PermissionRouting, Provider};
use crate::providers::errors::ProviderError;
use crate::subprocess::configure_subprocess;
/// Sentinel: resolved to SessionModelState.current_model_id at connect time.
pub const ACP_CURRENT_MODEL: &str = "current";
@@ -938,6 +939,7 @@ async fn spawn_acp_process(config: &AcpProviderConfig) -> Result<Child> {
cmd.env(key, value);
}
configure_subprocess(&mut cmd);
cmd.spawn().context("failed to spawn ACP process")
}
-1
View File
@@ -11,7 +11,6 @@ impl SubprocessExt for Command {
fn set_no_window(&mut self) -> &mut Self {
#[cfg(windows)]
{
use std::os::windows::process::CommandExt;
self.creation_flags(CREATE_NO_WINDOW_FLAG);
}
self