fix: ignore deprecated skills extension (#7139)

Signed-off-by: anonwurcod <anonwurcod@proton.me>
Co-authored-by: Warp <agent@warp.dev>
This commit is contained in:
fre$h
2026-02-13 15:30:26 -05:00
committed by GitHub
parent 5ba5b9899d
commit 58d3431bf5
2 changed files with 92 additions and 8 deletions
@@ -2,6 +2,7 @@
// Provides a simple way to store extension-specific data with versioned keys
use crate::config::base::Config;
use crate::config::extensions::is_extension_available;
use crate::config::ExtensionConfig;
use crate::session::SessionManager;
use anyhow::Result;
@@ -114,6 +115,12 @@ impl EnabledExtensionsState {
Self { extensions }
}
pub fn from_extension_data(extension_data: &ExtensionData) -> Option<Self> {
let mut state = <Self as ExtensionState>::from_extension_data(extension_data)?;
state.extensions.retain(is_extension_available);
Some(state)
}
pub fn extensions_or_default(
extension_data: Option<&ExtensionData>,
config: &Config,
@@ -259,4 +266,37 @@ mod tests {
Some(&json!({"key": "value"}))
);
}
#[test]
fn test_enabled_extensions_state_filters_unavailable_platform() {
let mut extension_data = ExtensionData::new();
let state = EnabledExtensionsState::new(vec![
ExtensionConfig::Platform {
name: "definitely_not_real_platform_extension".to_string(),
description: "unknown".to_string(),
display_name: None,
bundled: None,
available_tools: Vec::new(),
},
ExtensionConfig::Builtin {
name: "developer".to_string(),
description: "".to_string(),
display_name: Some("Developer".to_string()),
timeout: None,
bundled: None,
available_tools: Vec::new(),
},
]);
state.to_extension_data(&mut extension_data).unwrap();
let loaded =
EnabledExtensionsState::from_extension_data(&extension_data).expect("state present");
let names: Vec<String> = loaded.extensions.iter().map(|ext| ext.name()).collect();
assert!(names.iter().any(|name| name == "developer"));
assert!(!names
.iter()
.any(|name| name == "definitely_not_real_platform_extension"));
}
}