fix optional recipe schema zod validation (#4900)

ui/desktop/src/recipe/validation.ts

@@ -187,16 +187,19 @@ function openApiSchemaToZod(schema: Record<string, unknown>): z.ZodTypeAny {
           shape[propName] = openApiSchemaToZod(propSchema as Record<string, unknown>);
         }
 
-        // Make optional properties optional
+        // Make optional properties optional based on required array
-        if (schema.required && Array.isArray(schema.required)) {
         const optionalShape: Record<string, z.ZodTypeAny> = {};
+        const requiredFields =
+          schema.required && Array.isArray(schema.required) ? schema.required : [];
+
         for (const [propName, zodSchema] of Object.entries(shape)) {
-            if (schema.required.includes(propName)) {
+          if (requiredFields.includes(propName)) {
             optionalShape[propName] = zodSchema;
           } else {
             optionalShape[propName] = zodSchema.optional();
           }
         }
+
         let objectSchema = z.object(optionalShape);
 
         if (schema.additionalProperties === true) {
@@ -208,19 +211,6 @@ function openApiSchemaToZod(schema: Record<string, unknown>): z.ZodTypeAny {
         }
 
         return schema.nullable ? objectSchema.nullable() : objectSchema;
-        } else {
-          let objectSchema = z.object(shape);
-
-          if (schema.additionalProperties === true) {
-            return schema.nullable
-              ? objectSchema.passthrough().nullable()
-              : objectSchema.passthrough();
-          } else if (schema.additionalProperties === false) {
-            return schema.nullable ? objectSchema.strict().nullable() : objectSchema.strict();
-          }
-
-          return schema.nullable ? objectSchema.nullable() : objectSchema;
-        }
       }
       return schema.nullable ? z.record(z.any()).nullable() : z.record(z.any());