Don't load user's shell env on app startup (#4681)

Co-authored-by: Michael Neale <michael.neale@gmail.com>

ui/desktop/src/main.ts

@@ -25,7 +25,6 @@ import { spawn } from 'child_process';
 import 'dotenv/config';
 import { startGoosed } from './goosed';
 import { expandTilde, getBinaryPath } from './utils/pathUtils';
-import { loadShellEnv } from './utils/loadEnv';
 import log from './utils/logger';
 import { ensureWinShims } from './utils/winShims';
 import { addRecentDir, loadRecentDirs } from './utils/recentDirs';
@@ -448,46 +447,37 @@ const parseArgs = () => {
   return { dirPath };
 };
 
-const getGooseProvider = () => {
-  loadShellEnv(app.isPackaged);
+interface BundledConfig {
+  defaultProvider?: string;
+  defaultModel?: string;
+  predefinedModels?: string;
+  baseUrlShare?: string;
+  version?: string;
+}
+
+const getBundledConfig = (): BundledConfig => {
   //{env-macro-start}//
   //needed when goose is bundled for a specific provider
   //{env-macro-end}//
-  return [
-    process.env.GOOSE_DEFAULT_PROVIDER,
-    process.env.GOOSE_DEFAULT_MODEL,
-    process.env.GOOSE_PREDEFINED_MODELS,
-  ];
+  return {
+    defaultProvider: process.env.GOOSE_DEFAULT_PROVIDER,
+    defaultModel: process.env.GOOSE_DEFAULT_MODEL,
+    predefinedModels: process.env.GOOSE_PREDEFINED_MODELS,
+    baseUrlShare: process.env.GOOSE_BASE_URL_SHARE,
+    version: process.env.GOOSE_VERSION,
+  };
 };
 
-const getSharingUrl = () => {
-  // checks app env for sharing url
-  loadShellEnv(app.isPackaged); // will try to take it from the zshrc file
-  // if GOOSE_BASE_URL_SHARE is found, we will set process.env.GOOSE_BASE_URL_SHARE, otherwise we return what it is set
-  // to in the env at bundle time
-  return process.env.GOOSE_BASE_URL_SHARE;
-};
-
-const getVersion = () => {
-  // checks app env for sharing url
-  loadShellEnv(app.isPackaged); // will try to take it from the zshrc file
-  // to in the env at bundle time
-  return process.env.GOOSE_VERSION;
-};
-
-const [provider, model, predefinedModels] = getGooseProvider();
-
-const sharingUrl = getSharingUrl();
-
-const gooseVersion = getVersion();
+const { defaultProvider, defaultModel, predefinedModels, baseUrlShare, version } =
+  getBundledConfig();
 
 const SERVER_SECRET = process.env.GOOSE_EXTERNAL_BACKEND
   ? 'test'
   : crypto.randomBytes(32).toString('hex');
 
 let appConfig = {
-  GOOSE_DEFAULT_PROVIDER: provider,
-  GOOSE_DEFAULT_MODEL: model,
+  GOOSE_DEFAULT_PROVIDER: defaultProvider,
+  GOOSE_DEFAULT_MODEL: defaultModel,
   GOOSE_PREDEFINED_MODELS: predefinedModels,
   GOOSE_API_HOST: 'http://127.0.0.1',
   GOOSE_PORT: 0,
@@ -603,8 +593,8 @@ const createChat = async (
           GOOSE_PORT: port,
           GOOSE_WORKING_DIR: working_dir,
           REQUEST_DIR: dir,
-          GOOSE_BASE_URL_SHARE: sharingUrl,
-          GOOSE_VERSION: gooseVersion,
+          GOOSE_BASE_URL_SHARE: baseUrlShare,
+          GOOSE_VERSION: version,
           recipe: recipe,
         }),
       ],
@@ -1927,7 +1917,7 @@ async function appMain() {
       if (aboutGooseMenuItem.submenu) {
         aboutGooseMenuItem.submenu.append(
           new MenuItem({
-            label: `Version ${gooseVersion || app.getVersion()}`,
+            label: `Version ${version || app.getVersion()}`,
             enabled: false,
           })
         );

ui/desktop/src/utils/loadEnv.ts

@@ -1,38 +0,0 @@
-import { execSync } from 'child_process';
-import log from './logger';
-
-export function loadShellEnv(isProduction: boolean = false): void {
-  // Only proceed if running on macOS and in production mode
-  if (process.platform !== 'darwin' || !isProduction) {
-    log.info(
-      `Skipping zsh environment loading: ${
-        process.platform !== 'darwin' ? 'Not running on macOS' : 'Not in production mode'
-      }`
-    );
-    return;
-  }
-
-  try {
-    log.info('LOADING ENV');
-
-    const shell = process.env.SHELL || '/bin/bash'; // Detect user's shell
-
-    const envStr = execSync(`${shell} -l -i -c 'env'`, {
-      encoding: 'utf-8',
-    });
-
-    // Parse and set environment variables
-    envStr.split('\n').forEach((line) => {
-      const matches = line.match(/^([^=]+)=(.*)$/);
-      if (matches) {
-        const [, key, value] = matches;
-        log.info(`Setting ${key}`);
-        process.env[key] = value;
-      }
-    });
-
-    log.info('Successfully loaded zsh environment variables');
-  } catch (error) {
-    log.error('Failed to load zsh environment variables:', error);
-  }
-}