From 221aae407da6bb3b3d63054175a7f9b326adf8f1 Mon Sep 17 00:00:00 2001
From: Bradley Axen <baxen@squareup.com>
Date: Sun, 26 Jan 2025 14:42:23 -0800
Subject: [PATCH] fix: check url has required fields (#786)

---
 ui/desktop/src/extensions.tsx | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/ui/desktop/src/extensions.tsx b/ui/desktop/src/extensions.tsx
index 12d10fe7..761bfc4e 100644
--- a/ui/desktop/src/extensions.tsx
+++ b/ui/desktop/src/extensions.tsx
@@ -273,6 +273,19 @@ export async function addExtensionFromDeepLink(url: string, navigate: NavigateFu
     );
   }
 
+  // Check that all required fields are present and not empty
+  const requiredFields = ['name', 'description'];
+
+  for (const field of requiredFields) {
+    const value = parsedUrl.searchParams.get(field);
+    if (!value || value.trim() === '') {
+      handleError(
+        `Failed to install extension: The link is missing required field '${field}'`,
+        true
+      );
+    }
+  }
+
   const cmd = parsedUrl.searchParams.get('cmd');
   if (!cmd) {
     handleError("Failed to install extension: Missing required 'cmd' parameter in the URL", true);