lowercase g in goose (#4832)
This commit is contained in:
Angie Jones
@@ -192,10 +192,10 @@ jobs:
|
||||
source_job_url="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
|
||||
unsigned_url="s3://block-goose-artifacts-bucket-production/unsigned/goose-${GITHUB_SHA}-${{ github.run_id }}-intel.zip"
|
||||
|
||||
zip -q -u -r out/Goose-darwin-x64/Goose_intel_mac.zip entitlements.plist
|
||||
zip -q -u -r out/goose-darwin-x64/goose_intel_mac.zip entitlements.plist
|
||||
|
||||
# upload unsigned goose to transfer bucket so it can be passed to lambda
|
||||
aws s3 cp --quiet out/Goose-darwin-x64/Goose_intel_mac.zip "${unsigned_url}"
|
||||
aws s3 cp --quiet out/goose-darwin-x64/goose_intel_mac.zip "${unsigned_url}"
|
||||
|
||||
# begin signing
|
||||
echo "🚀 launching signing process"
|
||||
@@ -247,7 +247,7 @@ jobs:
|
||||
|
||||
# download the signed app from S3
|
||||
echo "⬇️ downloading signed app"
|
||||
aws s3 cp --quiet "${signed_url}" out/Goose-darwin-x64/Goose_intel_mac.zip
|
||||
aws s3 cp --quiet "${signed_url}" out/goose-darwin-x64/goose_intel_mac.zip
|
||||
working-directory: ui/desktop
|
||||
|
||||
- name: Final cleanup before artifact upload
|
||||
@@ -261,26 +261,26 @@ jobs:
|
||||
- name: Upload Desktop artifact
|
||||
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # pin@v4
|
||||
with:
|
||||
name: Goose-darwin-x64
|
||||
path: ui/desktop/out/Goose-darwin-x64/Goose_intel_mac.zip
|
||||
name: goose-darwin-x64
|
||||
path: ui/desktop/out/goose-darwin-x64/goose_intel_mac.zip
|
||||
|
||||
- name: Quick launch test (macOS)
|
||||
if: ${{ inputs.quick_test }}
|
||||
run: |
|
||||
# Ensure no quarantine attributes (if needed)
|
||||
xattr -cr "ui/desktop/out/Goose-darwin-x64/Goose.app"
|
||||
echo "Opening Goose.app..."
|
||||
open -g "ui/desktop/out/Goose-darwin-x64/Goose.app"
|
||||
xattr -cr "ui/desktop/out/goose-darwin-x64/goose.app"
|
||||
echo "Opening goose.app..."
|
||||
open -g "ui/desktop/out/goose-darwin-x64/goose.app"
|
||||
|
||||
# Give the app a few seconds to start and write logs
|
||||
sleep 5
|
||||
|
||||
# Check if it's running
|
||||
if pgrep -f "Goose.app/Contents/MacOS/Goose" > /dev/null; then
|
||||
if pgrep -f "goose.app/Contents/MacOS/goose" > /dev/null; then
|
||||
echo "App appears to be running."
|
||||
else
|
||||
echo "App did not stay open. Possible crash or startup error."
|
||||
exit 1
|
||||
fi
|
||||
# Kill the app to clean up
|
||||
pkill -f "Goose.app/Contents/MacOS/Goose"
|
||||
pkill -f "goose.app/Contents/MacOS/goose"
|
||||
|
||||
@@ -180,21 +180,21 @@ jobs:
|
||||
- name: Upload .deb package
|
||||
uses: actions/upload-artifact@v4
|
||||
with:
|
||||
name: Goose-linux-x64-deb
|
||||
name: goose-linux-x64-deb
|
||||
path: ui/desktop/out/make/deb/x64/*.deb
|
||||
if-no-files-found: error
|
||||
|
||||
- name: Upload .rpm package
|
||||
uses: actions/upload-artifact@v4
|
||||
with:
|
||||
name: Goose-linux-x64-rpm
|
||||
name: goose-linux-x64-rpm
|
||||
path: ui/desktop/out/make/rpm/x64/*.rpm
|
||||
if-no-files-found: error
|
||||
|
||||
- name: Upload combined Linux packages
|
||||
uses: actions/upload-artifact@v4
|
||||
with:
|
||||
name: Goose-linux-x64
|
||||
name: goose-linux-x64
|
||||
path: |
|
||||
ui/desktop/out/make/deb/x64/*.deb
|
||||
ui/desktop/out/make/rpm/x64/*.rpm
|
||||
|
||||
@@ -284,12 +284,12 @@ jobs:
|
||||
- name: Copy exe/dll to final out folder and prepare flat distribution
|
||||
run: |
|
||||
cd ui/desktop
|
||||
mkdir -p ./out/Goose-win32-x64/resources/bin
|
||||
rsync -av src/bin/ out/Goose-win32-x64/resources/bin/
|
||||
mkdir -p ./out/goose-win32-x64/resources/bin
|
||||
rsync -av src/bin/ out/goose-win32-x64/resources/bin/
|
||||
|
||||
# Create flat distribution structure
|
||||
mkdir -p ./dist-windows
|
||||
cp -r ./out/Goose-win32-x64/* ./dist-windows/
|
||||
cp -r ./out/goose-win32-x64/* ./dist-windows/
|
||||
|
||||
# Verify the final structure
|
||||
echo "📋 Final flat distribution structure:"
|
||||
@@ -318,8 +318,8 @@ jobs:
|
||||
wget -q https://github.com/ebourg/jsign/releases/download/6.0/jsign-6.0.jar -O jsign.jar
|
||||
echo "05ca18d4ab7b8c2183289b5378d32860f0ea0f3bdab1f1b8cae5894fb225fa8a jsign.jar" | sha256sum -c
|
||||
|
||||
# Sign the main Electron executable (Goose.exe)
|
||||
echo "🔐 Signing main Electron executable: Goose.exe"
|
||||
# Sign the main Electron executable (goose.exe)
|
||||
echo "🔐 Signing main Electron executable: goose.exe"
|
||||
cd ui/desktop/dist-windows/
|
||||
|
||||
java -jar ${GITHUB_WORKSPACE}/jsign.jar \
|
||||
@@ -329,12 +329,12 @@ jobs:
|
||||
--alias windows-codesign \
|
||||
--certfile "${GITHUB_WORKSPACE}/block-codesign-cert.pem" \
|
||||
--tsaurl "http://timestamp.digicert.com" \
|
||||
--name "Goose" \
|
||||
--name "goose" \
|
||||
--url "https://github.com/block/goose" \
|
||||
"Goose.exe"
|
||||
"goose.exe"
|
||||
|
||||
osslsigncode verify Goose.exe
|
||||
echo "✅ Main executable Goose.exe signed successfully"
|
||||
osslsigncode verify goose.exe
|
||||
echo "✅ Main executable goose.exe signed successfully"
|
||||
|
||||
# Sign the backend executable (goosed.exe)
|
||||
echo "🔐 Signing backend executable: goosed.exe"
|
||||
@@ -347,7 +347,7 @@ jobs:
|
||||
--alias windows-codesign \
|
||||
--certfile "${GITHUB_WORKSPACE}/block-codesign-cert.pem" \
|
||||
--tsaurl "http://timestamp.digicert.com" \
|
||||
--name "Goose Backend" \
|
||||
--name "goose Backend" \
|
||||
--url "https://github.com/block/goose" \
|
||||
"goosed.exe"
|
||||
|
||||
@@ -357,8 +357,8 @@ jobs:
|
||||
# Show final file status
|
||||
echo "📋 Final signed files:"
|
||||
cd ../../
|
||||
ls -la Goose.exe
|
||||
sha256sum Goose.exe
|
||||
ls -la goose.exe
|
||||
sha256sum goose.exe
|
||||
ls -la resources/bin/goosed.exe
|
||||
sha256sum resources/bin/goosed.exe
|
||||
|
||||
@@ -371,8 +371,8 @@ jobs:
|
||||
run: |
|
||||
echo "📋 Verifying both signed executables in final distribution:"
|
||||
echo "Main executable:"
|
||||
ls -la ui/desktop/dist-windows/Goose.exe
|
||||
osslsigncode verify ui/desktop/dist-windows/Goose.exe
|
||||
ls -la ui/desktop/dist-windows/goose.exe
|
||||
osslsigncode verify ui/desktop/dist-windows/goose.exe
|
||||
echo "✅ Main executable signature verification passed"
|
||||
|
||||
echo "Backend executable:"
|
||||
@@ -387,18 +387,18 @@ jobs:
|
||||
echo "📦 Creating Windows zip package..."
|
||||
|
||||
# Create a zip file from the dist-windows directory
|
||||
zip -r "Goose-win32-x64.zip" dist-windows/
|
||||
zip -r "goose-win32-x64.zip" dist-windows/
|
||||
|
||||
echo "✅ Windows zip package created:"
|
||||
ls -la Goose-win32-x64.zip
|
||||
ls -la goose-win32-x64.zip
|
||||
|
||||
# Also create the zip in the expected output structure for consistency
|
||||
mkdir -p out/Goose-win32-x64/
|
||||
cp Goose-win32-x64.zip out/Goose-win32-x64/
|
||||
mkdir -p out/goose-win32-x64/
|
||||
cp goose-win32-x64.zip out/goose-win32-x64/
|
||||
|
||||
# 11) Upload the final Windows build
|
||||
- name: Upload Windows build artifacts
|
||||
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # pin@v4
|
||||
with:
|
||||
name: Goose-win32-x64
|
||||
path: ui/desktop/out/Goose-win32-x64/Goose-win32-x64.zip
|
||||
name: goose-win32-x64
|
||||
path: ui/desktop/out/goose-win32-x64/goose-win32-x64.zip
|
||||
|
||||
@@ -226,10 +226,10 @@ jobs:
|
||||
source_job_url="https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
|
||||
unsigned_url="s3://block-goose-artifacts-bucket-production/unsigned/goose-${GITHUB_SHA}-${{ github.run_id }}-arm64.zip"
|
||||
|
||||
zip -q -u -r out/Goose-darwin-arm64/Goose.zip entitlements.plist
|
||||
zip -q -u -r out/goose-darwin-arm64/goose.zip entitlements.plist
|
||||
|
||||
# upload unsigned goose to transfer bucket so it can be passed to lambda
|
||||
aws s3 cp --quiet out/Goose-darwin-arm64/Goose.zip "${unsigned_url}"
|
||||
aws s3 cp --quiet out/goose-darwin-arm64/goose.zip "${unsigned_url}"
|
||||
|
||||
# begin signing
|
||||
echo "🚀 launching signing process"
|
||||
@@ -281,7 +281,7 @@ jobs:
|
||||
|
||||
# download the signed app from S3
|
||||
echo "⬇️ downloading signed app"
|
||||
aws s3 cp --quiet "${signed_url}" out/Goose-darwin-arm64/Goose.zip
|
||||
aws s3 cp --quiet "${signed_url}" out/goose-darwin-arm64/goose.zip
|
||||
working-directory: ui/desktop
|
||||
|
||||
- name: Final cleanup before artifact upload
|
||||
@@ -296,26 +296,26 @@ jobs:
|
||||
id: upload-app-bundle
|
||||
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # pin@v4
|
||||
with:
|
||||
name: Goose-darwin-arm64
|
||||
path: ui/desktop/out/Goose-darwin-arm64/Goose.zip
|
||||
name: goose-darwin-arm64
|
||||
path: ui/desktop/out/goose-darwin-arm64/goose.zip
|
||||
|
||||
- name: Quick launch test (macOS)
|
||||
if: ${{ inputs.quick_test }}
|
||||
run: |
|
||||
# Ensure no quarantine attributes (if needed)
|
||||
xattr -cr "ui/desktop/out/Goose-darwin-arm64/Goose.app"
|
||||
echo "Opening Goose.app..."
|
||||
open -g "ui/desktop/out/Goose-darwin-arm64/Goose.app"
|
||||
xattr -cr "ui/desktop/out/goose-darwin-arm64/goose.app"
|
||||
echo "Opening goose.app..."
|
||||
open -g "ui/desktop/out/goose-darwin-arm64/goose.app"
|
||||
|
||||
# Give the app a few seconds to start and write logs
|
||||
sleep 5
|
||||
|
||||
# Check if it's running
|
||||
if pgrep -f "Goose.app/Contents/MacOS/Goose" > /dev/null; then
|
||||
if pgrep -f "goose.app/Contents/MacOS/goose" > /dev/null; then
|
||||
echo "App appears to be running."
|
||||
else
|
||||
echo "App did not stay open. Possible crash or startup error."
|
||||
exit 1
|
||||
fi
|
||||
# Kill the app to clean up
|
||||
pkill -f "Goose.app/Contents/MacOS/Goose"
|
||||
pkill -f "goose.app/Contents/MacOS/goose"
|
||||
@@ -117,7 +117,6 @@ jobs:
|
||||
artifacts: |
|
||||
goose-*.tar.bz2
|
||||
goose-*.zip
|
||||
Goose*.zip
|
||||
*.deb
|
||||
*.rpm
|
||||
download_cli.sh
|
||||
|
||||
@@ -122,7 +122,6 @@ jobs:
|
||||
artifacts: |
|
||||
goose-*.tar.bz2
|
||||
goose-*.zip
|
||||
Goose*.zip
|
||||
*.deb
|
||||
*.rpm
|
||||
download_cli.sh
|
||||
|
||||
@@ -81,7 +81,7 @@ jobs:
|
||||
- name: Download Intel artifact
|
||||
uses: actions/download-artifact@cc203385981b70ca67e1cc392babf9cc229d5806 # pin@v4
|
||||
with:
|
||||
name: Goose-darwin-x64
|
||||
name: goose-darwin-x64
|
||||
path: intel-dist
|
||||
|
||||
- name: Comment on PR with Intel download link
|
||||
@@ -91,9 +91,9 @@ jobs:
|
||||
body: |
|
||||
### macOS Intel Desktop App (x64)
|
||||
|
||||
[💻 Download macOS Desktop App (Intel x64, signed)](https://nightly.link/${{ github.repository }}/actions/runs/${{ github.run_id }}/Goose-darwin-x64.zip)
|
||||
[💻 Download macOS Desktop App (Intel x64, signed)](https://nightly.link/${{ github.repository }}/actions/runs/${{ github.run_id }}/goose-darwin-x64.zip)
|
||||
|
||||
**Instructions:**
|
||||
After downloading, unzip the file and drag the Goose.app to your Applications folder. The app is signed and notarized for macOS.
|
||||
After downloading, unzip the file and drag the goose.app to your Applications folder. The app is signed and notarized for macOS.
|
||||
|
||||
This link is provided by nightly.link and will work even if you're not logged into GitHub.
|
||||
@@ -95,6 +95,6 @@ jobs:
|
||||
[🪟 Download Windows Desktop App (x64, signed)](https://nightly.link/${{ github.repository }}/actions/runs/${{ github.run_id }}/desktop-windows-dist.zip)
|
||||
|
||||
**Instructions:**
|
||||
After downloading, unzip the file and run Goose.exe. The app is signed for Windows.
|
||||
After downloading, unzip the file and run goose.exe. The app is signed for Windows.
|
||||
|
||||
This link is provided by nightly.link and will work even if you're not logged into GitHub.
|
||||
|
||||
@@ -125,7 +125,7 @@ jobs:
|
||||
- name: Download ARM64 artifact
|
||||
uses: actions/download-artifact@cc203385981b70ca67e1cc392babf9cc229d5806 # pin@v4
|
||||
with:
|
||||
name: Goose-darwin-arm64
|
||||
name: goose-darwin-arm64
|
||||
path: arm64-dist
|
||||
|
||||
- name: Comment on PR with ARM64 download link
|
||||
@@ -135,7 +135,7 @@ jobs:
|
||||
body: |
|
||||
### macOS ARM64 Desktop App (Apple Silicon)
|
||||
|
||||
[📱 Download macOS Desktop App (arm64, unsigned)](https://nightly.link/${{ github.repository }}/actions/runs/${{ github.run_id }}/Goose-darwin-arm64.zip)
|
||||
[📱 Download macOS Desktop App (arm64, unsigned)](https://nightly.link/${{ github.repository }}/actions/runs/${{ github.run_id }}/goose-darwin-arm64.zip)
|
||||
|
||||
**Instructions:**
|
||||
After downloading, unzip the file and drag the Goose.app to a location you prefer. The app is unsigned, so to run it run `xattr -r -d com.apple.quarantine '/path/to/Goose.app'` and then open the app
|
||||
After downloading, unzip the file and drag the goose.app to a location you prefer. The app is unsigned, so to run it run `xattr -r -d com.apple.quarantine '/path/to/goose.app'` and then open the app
|
||||
@@ -1,4 +1,4 @@
|
||||
name: Build Goose Release Candidate
|
||||
name: Build goose release candidate
|
||||
|
||||
on:
|
||||
pull_request:
|
||||
@@ -24,7 +24,7 @@ jobs:
|
||||
body: |
|
||||
### macOS ARM64 Desktop App (Apple Silicon)
|
||||
|
||||
[📱 Download macOS Desktop App (arm64, unsigned)](https://nightly.link/${{ github.repository }}/actions/runs/${{ github.run_id }}/Goose-darwin-arm64.zip)
|
||||
[📱 Download macOS Desktop App (arm64, unsigned)](https://nightly.link/${{ github.repository }}/actions/runs/${{ github.run_id }}/goose-darwin-arm64.zip)
|
||||
|
||||
**Instructions:**
|
||||
After downloading, unzip the file and drag the Goose.app to a location you prefer. The app is unsigned, so to run it run `xattr -r -d com.apple.quarantine '/path/to/Goose.app'` and then open the app
|
||||
After downloading, unzip the file and drag the goose.app to a location you prefer. The app is unsigned, so to run it run `xattr -r -d com.apple.quarantine '/path/to/goose.app'` and then open the app
|
||||
|
||||
@@ -106,7 +106,6 @@ jobs:
|
||||
artifacts: |
|
||||
goose-*.tar.bz2
|
||||
goose-*.zip
|
||||
Goose*.zip
|
||||
*.deb
|
||||
*.rpm
|
||||
download_cli.sh
|
||||
@@ -124,7 +123,6 @@ jobs:
|
||||
artifacts: |
|
||||
goose-*.tar.bz2
|
||||
goose-*.zip
|
||||
Goose*.zip
|
||||
*.deb
|
||||
*.rpm
|
||||
download_cli.sh
|
||||
|
||||
@@ -161,13 +161,13 @@ jobs:
|
||||
body: |
|
||||
## 🤖 Automated Test Addition
|
||||
|
||||
This PR was automatically generated by Goose to improve test coverage.
|
||||
This PR was automatically generated by goose to improve test coverage.
|
||||
|
||||
### What changed?
|
||||
Added a unit test for a previously untested function.
|
||||
|
||||
### Why?
|
||||
Part of our daily automated test coverage improvement initiative. Goose analyzes the codebase to find untested but important functions and creates focused unit tests for them.
|
||||
Part of our daily automated test coverage improvement initiative. goose analyzes the codebase to find untested but important functions and creates focused unit tests for them.
|
||||
|
||||
### Review checklist
|
||||
- [ ] Test is meaningful and actually tests the function
|
||||
|
||||
@@ -30,7 +30,7 @@ jobs:
|
||||
with:
|
||||
node-version: '20'
|
||||
|
||||
- name: Install and Configure Goose
|
||||
- name: Install and Configure goose
|
||||
run: |
|
||||
mkdir -p /home/runner/.local/bin
|
||||
curl -fsSL https://github.com/block/goose/releases/download/stable/download_cli.sh \
|
||||
@@ -219,7 +219,7 @@ jobs:
|
||||
2. If approved, we'll run a security scan
|
||||
3. Once merged, you'll receive $10 in OpenRouter credits (if email provided)
|
||||
|
||||
Thanks for contributing to the Goose Recipe Cookbook! 🎉`;
|
||||
Thanks for contributing to the goose Recipe Cookbook! 🎉`;
|
||||
} else {
|
||||
// Read validation details from file
|
||||
let validationDetails = '';
|
||||
|
||||
Reference in New Issue
Block a user