tkmind/tkmind_go
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

[fix] generic check for gemini compat (#5842)

Browse Source
This commit is contained in:
Bradley Axen
2025-11-23 16:51:00 -08:00
committed by GitHub
parent aba3d2980b
commit 0ff54ceec3
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/goose/src/providers/formats/databricks.rs
+6 -2
View File
@@ -263,7 +263,7 @@ pub fn format_tools(tools: &[Tool], model_name: &str) -> anyhow::Result<Vec<Valu
let mut tool_names = std::collections::HashSet::new(); let mut tool_names = std::collections::HashSet::new();
let mut result = Vec::new(); let mut result = Vec::new();
let is_gemini = model_name.starts_with("gemini"); let is_gemini = model_name.contains("gemini");
for tool in tools { for tool in tools {
if !tool_names.insert(&tool.name) { if !tool_names.insert(&tool.name) {
@@ -697,7 +697,11 @@ mod tests {
"http://json-schema.org/draft-07/schema#" "http://json-schema.org/draft-07/schema#"
); );
let spec = format_tools(&[tool], "gemini-2-5-flash")?; let spec = format_tools(&[tool.clone()], "gemini-2-5-flash")?;
assert!(spec[0]["function"]["parameters"].get("$schema").is_none());
assert_eq!(spec[0]["function"]["parameters"]["type"], "object");
let spec = format_tools(&[tool], "databricks-gemini-3-pro")?;
assert!(spec[0]["function"]["parameters"].get("$schema").is_none()); assert!(spec[0]["function"]["parameters"].get("$schema").is_none());
assert_eq!(spec[0]["function"]["parameters"]["type"], "object"); assert_eq!(spec[0]["function"]["parameters"]["type"], "object");