tkmind/tkmind_go
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

perf: deduplicate _goose/providers/list RPC call at startup (#8873)

Browse Source 
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Matt Toohey
2026-04-29 15:49:50 +10:00
committed by GitHub
parent 56b845904f
commit 0bb87daefd
3 changed files with 60 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ui/goose2/src/app/hooks/useAppStartup.ts
+19 -24
View File
@@ -2,6 +2,7 @@ import { useEffect } from "react";
import { useAgentStore } from "@/features/agents/stores/agentStore";
import { useChatSessionStore } from "@/features/chat/stores/chatSessionStore";
import { useProviderInventoryStore } from "@/features/providers/stores/providerInventoryStore";
import { discoverAcpProvidersFromEntries } from "@/shared/api/acp";
import { setNotificationHandler, getClient } from "@/shared/api/acpConnection";
import notificationHandler from "@/shared/api/acpNotificationHandler";
import { perfLog } from "@/shared/lib/perfLog";
@@ -47,46 +48,41 @@ export function useAppStartup() {
}
};
const loadProviders = async () => {
const loadProvidersAndInventory = async () => {
const t0 = performance.now();
store.setProvidersLoading(true);
try {
const { discoverAcpProviders } = await import("@/shared/api/acp");
const providers = await discoverAcpProviders();
store.setProviders(providers);
perfLog(
`[perf:startup] loadProviders done in ${(performance.now() - t0).toFixed(1)}ms (n=${providers.length})`,
);
} catch (err) {
console.error("Failed to load ACP providers on startup:", err);
} finally {
store.setProvidersLoading(false);
}
};
const loadProviderInventory = async () => {
const t0 = performance.now();
inventoryStore.setLoading(true);
try {
const { getProviderInventory } = await import(
"@/features/providers/api/inventory"
);
const entries = await getProviderInventory();
// Populate inventory store
inventoryStore.setEntries(entries);
// Derive ACP providers from the same response
const providers = discoverAcpProvidersFromEntries(entries);
store.setProviders(providers);
perfLog(
`[perf:startup] loadProviderInventory done in ${(performance.now() - t0).toFixed(1)}ms (n=${entries.length})`,
`[perf:startup] loadProvidersAndInventory done in ${(performance.now() - t0).toFixed(1)}ms (entries=${entries.length}, providers=${providers.length})`,
);
return entries;
} catch (err) {
console.error("Failed to load provider inventory on startup:", err);
console.error(
"Failed to load providers and inventory on startup:",
err,
);
return [];
} finally {
store.setProvidersLoading(false);
inventoryStore.setLoading(false);
}
};
const refreshConfiguredProviderInventory = async (
initialEntries?: Awaited<ReturnType<typeof loadProviderInventory>>,
initialEntries?: Awaited<ReturnType<typeof loadProvidersAndInventory>>,
) => {
try {
const entries =
@@ -146,15 +142,14 @@ export function useAppStartup() {
setActiveSession(null);
};
const inventoryLoad = loadProviderInventory();
const providersAndInventoryLoad = loadProvidersAndInventory();
await Promise.allSettled([
loadPersonas(),
loadProviders(),
inventoryLoad,
providersAndInventoryLoad,
loadSessionState(),
]);
void inventoryLoad.then((entries) =>
void providersAndInventoryLoad.then((entries) =>
refreshConfiguredProviderInventory(entries),
);
perfLog(