From 09589cca55819fba9a16cf0a42e15e6fce913e01 Mon Sep 17 00:00:00 2001 From: Jasper Date: Fri, 4 Sep 2026 11:07:34 +0000 Subject: [PATCH] fix(security): require HTTPS for Snowflake (#11745) --- crates/goose-providers/src/snowflake.rs | 44 ++++++++++++++++++++++++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/crates/goose-providers/src/snowflake.rs b/crates/goose-providers/src/snowflake.rs index d0fa2bc06..ddd1861df 100644 --- a/crates/goose-providers/src/snowflake.rs +++ b/crates/goose-providers/src/snowflake.rs @@ -77,8 +77,14 @@ impl SnowflakeProvider { host }; + let parsed_url = url::Url::parse(&base_url)?; + if parsed_url.scheme() != "https" { + anyhow::bail!("Snowflake host must use HTTPS"); + } + let auth = AuthMethod::BearerToken(token); - let mut api_client = ApiClient::new_with_tls(base_url, auth, tls_config)?; + let mut api_client = + ApiClient::new_with_tls(base_url, auth, tls_config)?.with_https_only()?; if let Some(request_builder) = request_builder { api_client = api_client.with_request_builder(request_builder); } @@ -353,3 +359,39 @@ impl Provider for SnowflakeProvider { )) } } + +#[cfg(test)] +mod tests { + use super::*; + + fn create_provider(host: &str) -> Result { + SnowflakeProvider::new(host.to_string(), "token".to_string(), None, None) + } + + #[test] + fn rejects_http_host() { + let error = create_provider("http://account.snowflakecomputing.com").unwrap_err(); + + assert!(error.to_string().contains("HTTPS")); + } + + #[test] + fn accepts_https_host() { + let provider = create_provider("https://account.snowflakecomputing.com").unwrap(); + + assert_eq!( + provider.api_client.host(), + "https://account.snowflakecomputing.com" + ); + } + + #[test] + fn normalizes_schemeless_host_to_https() { + let provider = create_provider("account").unwrap(); + + assert_eq!( + provider.api_client.host(), + "https://account.snowflakecomputing.com" + ); + } +}