View model interactions (#9806)

Signed-off-by: Douwe M Osinga <douwe@sidewalklabs.com>
Co-authored-by: Douwe M Osinga <douwe@sidewalklabs.com>
Co-authored-by: Michael Neale <michael.neale@gmail.com>

ui/desktop/src/__tests__/sessions.test.ts

@@ -1,5 +1,5 @@
 import { describe, it, expect } from 'vitest';
-import { getSessionDisplayName } from '../sessions';
+import { getSessionDisplayName, shouldShowNewChatTitle } from '../sessions';
 import { prependUnique } from '../hooks/useNavigationSessions';
 import type { Session } from '../api';
 import type { SessionListItem } from '../acp/sessions';
@@ -30,19 +30,51 @@ function makeListItem(overrides: Partial<SessionListItem> = {}): SessionListItem
   };
 }
 
-describe('getSessionDisplayName', () => {
-  it('returns the session name', () => {
-    const session = makeSession({
-      name: 'My Chat',
-    });
-    expect(getSessionDisplayName(session)).toBe('My Chat');
+describe('shouldShowNewChatTitle', () => {
+  it('returns true for an empty session without a user-set name', () => {
+    const session = makeSession({ message_count: 0, user_set_name: false });
+    expect(shouldShowNewChatTitle(session)).toBe(true);
   });
 
-  it('falls back to the default title when the session name is empty', () => {
+  it('returns false when the session has messages', () => {
+    const session = makeSession({ message_count: 3, user_set_name: false });
+    expect(shouldShowNewChatTitle(session)).toBe(false);
+  });
+
+  it('returns false when the user has set a custom name', () => {
+    const session = makeSession({ message_count: 0, user_set_name: true });
+    expect(shouldShowNewChatTitle(session)).toBe(false);
+  });
+
+  it('returns false when the session has a recipe', () => {
     const session = makeSession({
-      name: '',
+      message_count: 0,
+      user_set_name: false,
+      recipe: { title: 'Recipe', steps: [] } as unknown as Session['recipe'],
     });
-    expect(getSessionDisplayName(session)).toBe('New Chat');
+    expect(shouldShowNewChatTitle(session)).toBe(false);
+  });
+});
+
+describe('getSessionDisplayName (fix for #8865)', () => {
+  it('returns the user-set name for a recipe session that has been renamed', () => {
+    const session = makeSession({
+      name: 'My Renamed Chat',
+      user_set_name: true,
+      message_count: 2,
+      recipe: { title: 'Some Recipe' } as unknown as Session['recipe'],
+    });
+    expect(getSessionDisplayName(session)).toBe('My Renamed Chat');
+  });
+
+  it('falls back to the recipe title when the user has not renamed', () => {
+    const session = makeSession({
+      name: 'auto-generated',
+      user_set_name: false,
+      message_count: 2,
+      recipe: { title: 'Some Recipe' } as unknown as Session['recipe'],
+    });
+    expect(getSessionDisplayName(session)).toBe('Some Recipe');
   });
 });