tkmind/tkmind_go
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

deps: upgrade agent-client-protocol to 0.9.0 (#6109)

Browse Source 
Signed-off-by: Adrian Cole <adrian@tetrate.io>
This commit is contained in:
Adrian Cole
2025-12-17 01:50:47 +01:00
committed by GitHub
parent 34b20ae0fe
commit 062fc07432
4 changed files with 186 additions and 183 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/goose-cli/Cargo.toml
+1 -1
View File
@@ -19,7 +19,7 @@ goose = { path = "../goose" }
goose-bench = { path = "../goose-bench" }
goose-mcp = { path = "../goose-mcp" }
rmcp = { workspace = true }
agent-client-protocol = "0.4.0"
agent-client-protocol = "0.9.0"
clap = { version = "4.4", features = ["derive"] }
cliclack = "0.3.5"
console = "0.15.8"
crates/goose-cli/src/commands/acp.rs
+107 -177
View File
@@ -1,6 +1,6 @@
use agent_client_protocol::{
self as acp, Client, EmbeddedResource, ImageContent, SessionNotification, TextContent,
ToolCallContent,
self as acp, Client, Content, ContentChunk, EmbeddedResource, ExtResponse, ImageContent,
ProtocolVersion, SessionNotification, TextContent, ToolCallContent,
};
use anyhow::Result;
use goose::agents::{Agent, SessionConfig};
@@ -37,11 +37,7 @@ struct GooseAcpAgent {
/// Create a ToolCallLocation with common defaults
fn create_tool_location(path: &str, line: Option<u32>) -> acp::ToolCallLocation {
acp::ToolCallLocation {
path: path.into(),
line,
meta: None,
}
acp::ToolCallLocation::new(path).line(line)
}
/// Extract file locations from tool request and response
@@ -320,6 +316,7 @@ impl GooseAcpAgent {
}
}
acp::ContentBlock::Audio(..) => (),
_ => (),
}
}
@@ -338,13 +335,12 @@ impl GooseAcpAgent {
let (tx, rx) = oneshot::channel();
self.session_update_tx
.send((
SessionNotification {
session_id: session_id.clone(),
update: acp::SessionUpdate::AgentMessageChunk {
content: text.text.clone().into(),
},
meta: None,
},
SessionNotification::new(
session_id.clone(),
acp::SessionUpdate::AgentMessageChunk(ContentChunk::new(
acp::ContentBlock::Text(TextContent::new(text.text.clone())),
)),
),
tx,
))
.map_err(|_| acp::Error::internal_error())?;
@@ -363,13 +359,14 @@ impl GooseAcpAgent {
let (tx, rx) = oneshot::channel();
self.session_update_tx
.send((
SessionNotification {
session_id: session_id.clone(),
update: acp::SessionUpdate::AgentThoughtChunk {
content: thinking.thinking.clone().into(),
},
meta: None,
},
SessionNotification::new(
session_id.clone(),
acp::SessionUpdate::AgentThoughtChunk(ContentChunk::new(
acp::ContentBlock::Text(TextContent::new(
thinking.thinking.clone(),
)),
)),
),
tx,
))
.map_err(|_| acp::Error::internal_error())?;
@@ -410,21 +407,16 @@ impl GooseAcpAgent {
let (tx, rx) = oneshot::channel();
self.session_update_tx
.send((
SessionNotification {
session_id: session_id.clone(),
update: acp::SessionUpdate::ToolCall(acp::ToolCall {
id: acp::ToolCallId(acp_tool_id.clone().into()),
title: format_tool_name(&tool_name),
kind: acp::ToolKind::default(),
status: acp::ToolCallStatus::Pending,
content: Vec::new(),
locations: Vec::new(), // Will be populated in handle_tool_response
raw_input: None,
raw_output: None,
meta: None,
}),
meta: None,
},
SessionNotification::new(
session_id.clone(),
acp::SessionUpdate::ToolCall(
acp::ToolCall::new(
acp::ToolCallId::new(acp_tool_id.clone()),
format_tool_name(&tool_name),
)
.status(acp::ToolCallStatus::Pending),
),
),
tx,
))
.map_err(|_| acp::Error::internal_error())?;
@@ -462,24 +454,20 @@ impl GooseAcpAgent {
let (tx, rx) = oneshot::channel();
self.session_update_tx
.send((
SessionNotification {
session_id: session_id.clone(),
update: acp::SessionUpdate::ToolCallUpdate(acp::ToolCallUpdate {
id: acp::ToolCallId(acp_tool_id.clone().into()),
fields: acp::ToolCallUpdateFields {
status: Some(status),
content: Some(content),
locations: if locations.is_empty() {
SessionNotification::new(
session_id.clone(),
acp::SessionUpdate::ToolCallUpdate(acp::ToolCallUpdate::new(
acp::ToolCallId::new(acp_tool_id.clone()),
acp::ToolCallUpdateFields::new()
.status(status)
.content(content)
.locations(if locations.is_empty() {
None
} else {
Some(locations)
},
..Default::default()
},
meta: None,
}),
meta: None,
},
}),
)),
),
tx,
))
.map_err(|_| acp::Error::internal_error())?;
@@ -497,56 +485,37 @@ fn build_tool_call_content(tool_result: &ToolResult<CallToolResult>) -> Vec<Tool
.content
.iter()
.filter_map(|content| match &content.raw {
RawContent::Text(val) => Some(ToolCallContent::Content {
content: acp::ContentBlock::Text(TextContent {
annotations: None,
text: val.text.clone(),
meta: None,
}),
}),
RawContent::Image(val) => Some(ToolCallContent::Content {
content: acp::ContentBlock::Image(ImageContent {
annotations: None,
data: val.data.clone(),
mime_type: val.mime_type.clone(),
uri: None,
meta: None,
}),
}),
RawContent::Resource(val) => Some(ToolCallContent::Content {
content: acp::ContentBlock::Resource(EmbeddedResource {
annotations: None,
resource: match &val.resource {
ResourceContents::TextResourceContents {
mime_type,
text,
uri,
..
} => acp::EmbeddedResourceResource::TextResourceContents(
acp::TextResourceContents {
mime_type: mime_type.clone(),
text: text.clone(),
uri: uri.clone(),
meta: None,
},
),
ResourceContents::BlobResourceContents {
mime_type,
blob,
uri,
..
} => acp::EmbeddedResourceResource::BlobResourceContents(
acp::BlobResourceContents {
mime_type: mime_type.clone(),
blob: blob.clone(),
uri: uri.clone(),
meta: None,
},
),
},
meta: None,
}),
}),
RawContent::Text(val) => Some(ToolCallContent::Content(Content::new(
acp::ContentBlock::Text(TextContent::new(val.text.clone())),
))),
RawContent::Image(val) => Some(ToolCallContent::Content(Content::new(
acp::ContentBlock::Image(ImageContent::new(
val.data.clone(),
val.mime_type.clone(),
)),
))),
RawContent::Resource(val) => Some(ToolCallContent::Content(Content::new(
acp::ContentBlock::Resource(EmbeddedResource::new(match &val.resource {
ResourceContents::TextResourceContents {
mime_type,
text,
uri,
..
} => acp::EmbeddedResourceResource::TextResourceContents(
acp::TextResourceContents::new(text.clone(), uri.clone())
.mime_type(mime_type.clone()),
),
ResourceContents::BlobResourceContents {
mime_type,
blob,
uri,
..
} => acp::EmbeddedResourceResource::BlobResourceContents(
acp::BlobResourceContents::new(blob.clone(), uri.clone())
.mime_type(mime_type.clone()),
),
})),
))),
RawContent::Audio(_) => {
// Audio content is not supported in ACP ContentBlock, skip it
None
@@ -570,28 +539,17 @@ impl acp::Agent for GooseAcpAgent {
info!("ACP: Received initialize request {:?}", args);
// Advertise Goose's capabilities
let agent_capabilities = acp::AgentCapabilities {
load_session: true,
prompt_capabilities: acp::PromptCapabilities {
image: true, // Goose supports image inputs via providers
audio: false, // TODO: Add audio support when providers support it
embedded_context: true, // Goose can handle embedded context resources
meta: None,
},
mcp_capabilities: acp::McpCapabilities {
http: false, // TODO: Add MCP HTTP support if needed
sse: false, // TODO: Add MCP SSE support if needed
meta: None,
},
meta: None,
};
Ok(acp::InitializeResponse {
protocol_version: acp::V1,
agent_capabilities,
auth_methods: Vec::new(),
meta: None,
})
let agent_capabilities = acp::AgentCapabilities::new()
.load_session(true)
.prompt_capabilities(
acp::PromptCapabilities::new()
.image(true)
.embedded_context(true),
);
Ok(
acp::InitializeResponse::new(ProtocolVersion::V1)
.agent_capabilities(agent_capabilities),
)
}
async fn authenticate(
@@ -599,7 +557,7 @@ impl acp::Agent for GooseAcpAgent {
args: acp::AuthenticateRequest,
) -> Result<acp::AuthenticateResponse, acp::Error> {
info!("ACP: Received authenticate request {:?}", args);
Ok(acp::AuthenticateResponse { meta: None })
Ok(acp::AuthenticateResponse::new())
}
async fn new_session(
@@ -627,11 +585,7 @@ impl acp::Agent for GooseAcpAgent {
info!("Created new ACP/goose session {}", goose_session.id);
Ok(acp::NewSessionResponse {
session_id: acp::SessionId(goose_session.id.into()),
modes: None,
meta: None,
})
Ok(acp::NewSessionResponse::new(goose_session.id))
}
async fn load_session(
@@ -681,21 +635,17 @@ impl acp::Agent for GooseAcpAgent {
match content_item {
MessageContent::Text(text) => {
let update = match message.role {
Role::User => acp::SessionUpdate::UserMessageChunk {
content: text.text.clone().into(),
},
Role::Assistant => acp::SessionUpdate::AgentMessageChunk {
content: text.text.clone().into(),
},
Role::User => acp::SessionUpdate::UserMessageChunk(ContentChunk::new(
text.text.clone().into(),
)),
Role::Assistant => acp::SessionUpdate::AgentMessageChunk(
ContentChunk::new(text.text.clone().into()),
),
};
let (tx, rx) = oneshot::channel();
self.session_update_tx
.send((
SessionNotification {
session_id: args.session_id.clone(),
update,
meta: None,
},
SessionNotification::new(args.session_id.clone(), update),
tx,
))
.map_err(|_| acp::Error::internal_error())?;
@@ -713,13 +663,12 @@ impl acp::Agent for GooseAcpAgent {
let (tx, rx) = oneshot::channel();
self.session_update_tx
.send((
SessionNotification {
session_id: args.session_id.clone(),
update: acp::SessionUpdate::AgentThoughtChunk {
content: thinking.thinking.clone().into(),
},
meta: None,
},
SessionNotification::new(
args.session_id.clone(),
acp::SessionUpdate::AgentThoughtChunk(ContentChunk::new(
thinking.thinking.clone().into(),
)),
),
tx,
))
.map_err(|_| acp::Error::internal_error())?;
@@ -737,10 +686,7 @@ impl acp::Agent for GooseAcpAgent {
info!("Loaded ACP session {}", session_id);
Ok(acp::LoadSessionResponse {
modes: None,
meta: None,
})
Ok(acp::LoadSessionResponse::new())
}
async fn prompt(&self, args: acp::PromptRequest) -> Result<acp::PromptResponse, acp::Error> {
@@ -810,14 +756,11 @@ impl acp::Agent for GooseAcpAgent {
session.cancel_token = None;
}
Ok(acp::PromptResponse {
stop_reason: if was_cancelled {
acp::StopReason::Cancelled
} else {
acp::StopReason::EndTurn
},
meta: None,
})
Ok(acp::PromptResponse::new(if was_cancelled {
acp::StopReason::Cancelled
} else {
acp::StopReason::EndTurn
}))
}
async fn cancel(&self, args: acp::CancelNotification) -> Result<(), acp::Error> {
@@ -842,20 +785,14 @@ impl acp::Agent for GooseAcpAgent {
&self,
_args: acp::SetSessionModeRequest,
) -> Result<acp::SetSessionModeResponse, acp::Error> {
// TODO: Implement session modes if needed
Err(acp::Error::method_not_found())
}
async fn ext_method(
&self,
_args: acp::ExtRequest,
) -> Result<std::sync::Arc<acp::RawValue>, acp::Error> {
// TODO: Implement extension methods if needed
async fn ext_method(&self, _args: acp::ExtRequest) -> Result<ExtResponse, acp::Error> {
Err(acp::Error::method_not_found())
}
async fn ext_notification(&self, _args: acp::ExtNotification) -> Result<(), acp::Error> {
// TODO: Implement extension notifications if needed
Ok(())
}
}
@@ -917,21 +854,14 @@ mod tests {
let mut file = NamedTempFile::new()?;
file.write_all(content.as_bytes())?;
let link = ResourceLink {
annotations: None,
description: None,
mime_type: None,
name: file
.path()
let link = ResourceLink::new(
file.path()
.file_name()
.unwrap()
.to_string_lossy()
.to_string(),
size: None,
title: None,
uri: format!("file://{}", file.path().to_str().unwrap()),
meta: None,
};
format!("file://{}", file.path().to_str().unwrap()),
);
Ok((link, file))
}
crates/goose-mcp/src/computercontroller/mod.rs
+1 -1
View File
@@ -1122,7 +1122,7 @@ impl ComputerControllerServer {
let json_params = params
.params
.as_ref()
.map(|p| serde_json::to_value(p).unwrap_or_else(|_| serde_json::Value::Null));
.map(|p| serde_json::to_value(p).unwrap_or(serde_json::Value::Null));
let result = crate::computercontroller::docx_tool::docx_tool(
path,